perf: Querify some things that are called by the solver and are fairly expensive to compute - #23207
Open
ChayimFriedman2 wants to merge 1 commit into
Open
perf: Querify some things that are called by the solver and are fairly expensive to compute#23207ChayimFriedman2 wants to merge 1 commit into
ChayimFriedman2 wants to merge 1 commit into
Conversation
…nsive to compute I'm conflicted about this. One one hand, the memory impact isn't large: 2mb on rust-analyzer, 13mb on buck2 and 14mb on omicron. On the other hand, the speed gains aren't large as well: ~2 seconds on rust-analyzer or 2 ginstructions (0.4%). So I figured I'll let others decide.
rustbot
added
the
S-waiting-on-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm conflicted about this. One one hand, the memory impact isn't large: 2mb on rust-analyzer, 13mb on buck2 and 14mb on omicron. On the other hand, the speed gains aren't large as well: ~2 seconds on rust-analyzer or 2 ginstructions (0.4%). So I figured I'll let others decide.